On 2026/1/19 09:34, Hongbo Li wrote:
Hi, Xiang

On 2026/1/16 23:38, Christoph Hellwig wrote:
+#if defined(CONFIG_EROFS_FS_ONDEMAND)

Normally this would just use #ifdef.

How about using #ifdef for all of them? I checked and there are only three 
places in total, and all of them are related to FS_PAGE_CACHE_SHARE or 
FS_ONDEMAND config macro.

I'm fine with most cases (including here).

But I'm not sure if there is a case as `#if defined() || defined()`,
it seems it cannot be simply replaced with `#ifdef`.

Thanks,
Gao Xiang


Thanks,
Hongbo


Reply via email to