Hi Takashi,

I was looking at online defrag code and found that the tmp_inode is created with tmp_inode->i_nlink equal to zero. Now i am not sure whether i understand the code correctly, but AFAIU we allocate contiguous block using this tmp_inode. That means tmp_inode have extent details corresponding to the blocks. Now we are mapping the file data found in the original inode to this new blocks. Towards the end we does a iput. In iput since we have i_nlink as zero it will go ahead and call generic_delete_inode which will cause these data blocks to be marked free (right ?)


I haven't tested the defrag code. This came up when i was doing the online migration. With large file having large number of fragmented blocks I was getting the below error during the iput of the temporary inode.

"ext4_free_blocks Freeing blocks not in datazone ...."

I was able to fix that by setting i_nlink = 1 which will cause the generic_forget_inode to be called


-aneesh
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to