On Oct 15, 2007  16:25 +0530, Aneesh Kumar K.V wrote:
> -             if (!EXT4_HAS_INCOMPAT_FEATURE(sb, 
> EXT4_FEATURE_INCOMPAT_EXTENTS)) {
> -                     err = ext4_journal_get_write_access(handle, 
> EXT4_SB(sb)->s_sbh);
> -                     if (err) goto fail;
> -                     EXT4_SET_INCOMPAT_FEATURE(sb, 
> EXT4_FEATURE_INCOMPAT_EXTENTS);
> -                     BUFFER_TRACE(EXT4_SB(sb)->s_sbh, "call 
> ext4_journal_dirty_metadata");
> -                     err = ext4_journal_dirty_metadata(handle, 
> EXT4_SB(sb)->s_sbh);
> -             }
> +             err = ext4_update_incompat_feature(handle, sb,
> +                                             EXT4_FEATURE_INCOMPAT_EXTENTS);
> +             if (err)
> +                     goto fail;
> +
> +             BUFFER_TRACE(EXT4_SB(sb)->s_sbh, "call ext4_update_feautre");

You may as well put the BUFFER_TRACE() all into
ext4_update_incompat_feature().

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to