On Nov 01, 2007 17:40 -0700, Mingming Cao wrote: > Current journal checksumming patch failed fsstress test on NUMA. The > bh->b_data passed to the crc32_be () function could be NULL pointer, > which caused kernel oops immediately when running fsstress with -o > journal_checksum. It is because the page is part of highmem on NUMA box. > We need to kmap the page before access the bh->b_data to calculate > the checksums.
I have no objection to the patch, per-se, but I'm surprised that there would ever be a buffer head pointing at a page in high memory? That seems contrary to what I would expect... Cheers, Andreas -- Andreas Dilger Sr. Software Engineer, Lustre Group Sun Microsystems of Canada, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
