On Mon, Aug 29, 2016 at 07:50:24PM +0300, Alexander Gordeev wrote:
> Hi,
>
> I have an update about the first of the bugs, that I reported.
>
> 19.08.2016, 20:23, "Alexander Gordeev" <[email protected]>:
> > Hi,
> >
> > I'd also like to report two bugs. I used f2fs-stable branch linux-3.10.y.
> > I'm using some proprietary modules also, but in my understanding they
> > shouldn't affect the fs.
> >
> > 1. I have a Sandisk 16GB microSDHC card, that is quite old and may be at
> > its end of life.
> > The bug is produced every time I try to delete any file on it.
> >
...
> As you can see, after to warnings goes an oops. I think it was overlooked.
> But it makes the most trouble to me.
>
> I tried to understand what's going on.
> It turns out that se->cur_valid_map is NULL in update_sit_entry().
> Probably, this is not expected.
Thank you for the analysis. :)
It seems the blkaddr is out-of-range.
Can you print out its blkaddr?
If possible, could you print out:
curseg->segno, curseg->next_blkoff,a curseg->next_segno
at the end of allocate_segment_by_default()?
Thanks,
>
> I made this patch:
>
> diff --git a/ambarella/kernel/linux-3.10/fs/f2fs/segment.c
> b/ambarella/kernel/linux-3.10/fs/f2fs/segment.c
> index 20eb067..767394e 100644
> --- a/ambarella/kernel/linux-3.10/fs/f2fs/segment.c
> +++ b/ambarella/kernel/linux-3.10/fs/f2fs/segment.c
> @@ -872,6 +872,7 @@ static void update_sit_entry(struct f2fs_sb_info *sbi,
> block_t blkaddr, int del)
>
> /* Update valid block bitmap */
> if (del > 0) {
> + f2fs_bug_on(sbi, !se->cur_valid_map);
> if (f2fs_test_and_set_bit(offset, se->cur_valid_map))
> f2fs_bug_on(sbi, 1);
> if (!f2fs_test_and_set_bit(offset, se->discard_map))
>
> And got this new warning:
>
> [ 49.878738] ------------[ cut here ]------------
> [ 49.913650] WARNING: at
> /home/alex/work/s2l/amb_S2l_SDK_2.5/SDK2.5/s2l_linux_sdk/ambarella/kernel/linux-3.10/fs/f2fs/segment.c:875
> update_sit_entry+0xfc/0x274 [f2fs]()
> [ 49.956951] Modules linked in: crc32 f2fs ov4689_mipi(PO) xt_tcpudp
> nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack iptable_filter
> ip_tables x_tables sd_mod bcmdhd(O) cfg80v
> [ 50.047314] CPU: 0 PID: 421 Comm: f2fs_gc-8:0 Tainted: P W O
> 3.10.93 #1
> [ 50.066051] [<800128d0>] (unwind_backtrace+0x0/0x118) from [<80011180>]
> (show_stack+0x10/0x14)
> [ 50.097576] [<80011180>] (show_stack+0x10/0x14) from [<80020200>]
> (warn_slowpath_common+0x4c/0x68)
> [ 50.117019] [<80020200>] (warn_slowpath_common+0x4c/0x68) from
> [<800202ac>] (warn_slowpath_null+0x18/0x20)
> [ 50.127578] [<800202ac>] (warn_slowpath_null+0x18/0x20) from [<7f536b08>]
> (update_sit_entry+0xfc/0x274 [f2fs])
> [ 50.145997] [<7f536b08>] (update_sit_entry+0xfc/0x274 [f2fs]) from
> [<7f538838>] (refresh_sit_entry+0x1c/0xb8 [f2fs])
> [ 50.157110] [<7f538838>] (refresh_sit_entry+0x1c/0xb8 [f2fs]) from
> [<7f539840>] (allocate_data_block+0x238/0x318 [f2fs])
> [ 50.170414] [<7f539840>] (allocate_data_block+0x238/0x318 [f2fs]) from
> [<7f539b44>] (do_write_page+0x224/0x270 [f2fs])
> [ 50.211114] [<7f539b44>] (do_write_page+0x224/0x270 [f2fs]) from
> [<7f539c28>] (write_node_page+0x38/0x40 [f2fs])
> [ 50.235535] [<7f539c28>] (write_node_page+0x38/0x40 [f2fs]) from
> [<7f5322fc>] (f2fs_write_node_page+0x1f8/0x2e4 [f2fs])
> [ 50.262378] [<7f5322fc>] (f2fs_write_node_page+0x1f8/0x2e4 [f2fs]) from
> [<7f533a48>] (move_node_page+0xa8/0xe8 [f2fs])
> [ 50.303626] [<7f533a48>] (move_node_page+0xa8/0xe8 [f2fs]) from
> [<7f52ac60>] (do_garbage_collect+0x3b8/0xbbc [f2fs])
> [ 50.316456] [<7f52ac60>] (do_garbage_collect+0x3b8/0xbbc [f2fs]) from
> [<7f52b768>] (f2fs_gc+0x304/0x4e8 [f2fs])
> [ 50.327530] [<7f52b768>] (f2fs_gc+0x304/0x4e8 [f2fs]) from [<7f52bbc0>]
> (gc_thread_func+0x274/0x368 [f2fs])
> [ 50.340949] [<7f52bbc0>] (gc_thread_func+0x274/0x368 [f2fs]) from
> [<8003eb28>] (kthread+0xa0/0xac)
> [ 50.350623] [<8003eb28>] (kthread+0xa0/0xac) from [<8000dd60>]
> (ret_from_fork+0x14/0x34)
> [ 50.359590] ---[ end trace 2e2fd9e8fd78501a ]---
>
> --
> Alexander
------------------------------------------------------------------------------
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
