On 2017/5/23 8:39, Eric Biggers wrote: > From: Eric Biggers <[email protected]> > > Since only an open file can be written to, and we only allow open()ing > an encrypted file when its key is available, there is no need to check > for the key again before permitting each ->write_iter(). > > This code was also broken in that it wouldn't actually have failed if > the key was in fact unavailable. > > Signed-off-by: Eric Biggers <[email protected]>
Acked-by: Chao Yu <[email protected]> Thanks, > --- > fs/f2fs/file.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index ff4db3efc0ac..3ccc63089a47 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -2318,11 +2318,6 @@ static ssize_t f2fs_file_write_iter(struct kiocb > *iocb, struct iov_iter *from) > struct blk_plug plug; > ssize_t ret; > > - if (f2fs_encrypted_inode(inode) && > - !fscrypt_has_encryption_key(inode) && > - fscrypt_get_encryption_info(inode)) > - return -EACCES; > - > inode_lock(inode); > ret = generic_write_checks(iocb, from); > if (ret > 0) { > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
