Hi Daeho, On 2018/1/9 17:59, Daeho Jeong wrote: > Hi, Chao > >> How can we build such xattr entry whose value is NULL? Can you give an >> reproducer example? > > We used setxattr system call with "value" as NULL and "size" as 0. > And then vfs_setxattr will change "value" to "" and transfer "value" and > "size" > to f2fs_setxattr().
Correct, I can reproduce this bug with: 1. touch file 2. setfattr -n "user.foo" file 3. setfattr -x "user.foo" file 4. getfattr -d file user.foo After applying your patch, the problem can be fixed. Could you add below test case explicitly in your commit log? Reviewed-by: Chao Yu <[email protected]> Tested-by: Chao Yu <[email protected]> Thanks, > > Thanks, > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Linux-f2fs-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
