On 01/10, Chao Yu wrote:
> This patch fix to cover f2fs_fiemap with inode_lock in order to make
> the whole interface avoiding race with mapping change.
>
> Signed-off-by: Chao Yu <[email protected]>
> ---
> fs/f2fs/data.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index d6302051a65d..330085d3adfc 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1146,18 +1146,18 @@ int f2fs_fiemap(struct inode *inode, struct
> fiemap_extent_info *fieinfo,
> u32 flags = 0;
> int ret = 0;
>
> + inode_lock(inode);
> +
> ret = fiemap_check_flags(fieinfo, FIEMAP_FLAG_SYNC);
> if (ret)
> - return ret;
> + goto out;
Uh? We don't need to cover fiemap_check_flags() by inode_lock().
>
> if (f2fs_has_inline_data(inode)) {
> ret = f2fs_inline_data_fiemap(inode, fieinfo, start, len);
> if (ret != -EAGAIN)
> - return ret;
> + goto out;
> }
>
> - inode_lock(inode);
> -
> if (logical_to_blk(inode, len) == 0)
> len = blk_to_logical(inode, 1);
>
> --
> 2.15.0.55.gc2ece9dc4de6
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
