Hi Park,

Sorry for late replying.

On 2018/3/19 11:53, Ju Hyung Park wrote:
> Hi Chao,
> 
>> Do you run this script in android environment to get the cold type?
> Yes, both on Ubuntu and Android(on /data with root permission).
> 
>> Actually, I doubt that '+1M' condition can't indicate that the file is cold 
>> or
>> not, and after run this script in my cell phone,
> Would it make sense to set a file that's < 1M as cold?

Like .so?

> I didn't think so. Please let me know if I'm wrong.
> 
>> I didn't see so many type as your patch adds.
> Of course, most of those were added from vlc and p7zip.
> There are tons more, but I added ones that are most common.
> While I personally don't have that much many types myself as well,
> I can easily see one having those extensions stored under f2fs.
> 
> Previous list was not enough, imo.
> (After running the command, I've added exo and ?dex files for Android.)
> 
>> If that is a common cold file type list that user may not do random updates 
>> in
>> the file after its creation,
> That's exactly what I intended.
> 
>> I suggest that we can add one common list instead
>> of changing old one controlled by mkfs option
> The new list is superset of the old list.
> A few extensions were removed as those are mostly deprecated formats
> and to make room for much more important extensions to be added such as m4a.

I agree that we'd better support the superset list of common static file, but
also I hope there is flexible usage of common list, old list and self defined
list, so I think we'd better leave enough free space of cold list to let user
define private cold file type extension as they wish, meanwhile support an
option to make user have a chance to choose the common list or old list.

How do you think?

Hi Jaegeuk, what's your opinion?

Thanks,

> 
> Thanks.
> 
> 
> On Mon, Mar 19, 2018 at 12:42 PM, Chao Yu <yuch...@huawei.com> wrote:
>> Hi Park,
>>
>> On 2018/3/17 23:02, Park Ju Hyung wrote:
>>> Those formats are large in size and rarely updated.
>>>
>>> Formats such as tar and zip were intentionally excluded as
>>> those are capable of random updates.
>>>
>>> (Added from vlc, p7zip and running
>>> 'find . -type f -size +1M |
>>>     while read FILE; do echo ${FILE##*.}; done |
>>>     sort | uniq -c | sort -nr'
>>> manually)
>>
>> Do you run this script in android environment to get the cold type?
>>
>> Actually, I doubt that '+1M' condition can't indicate that the file is cold 
>> or
>> not, and after run this script in my cell phone, I didn't see so many type as
>> your patch adds.
>>
>> If that is a common cold file type list that user may not do random updates 
>> in
>> the file after its creation, I suggest that we can add one common list 
>> instead
>> of changing old one controlled by mkfs option, anyway, to use which one, the
>> option can be decided by user.
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Park Ju Hyung <qkrwngud...@gmail.com>
>>> ---
>>>  mkfs/f2fs_format.c | 86 
>>> ++++++++++++++++++++++++++++++++++++++++--------------
>>>  1 file changed, 64 insertions(+), 22 deletions(-)
>>>
>>> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
>>> index 65692bb..3c7ce16 100644
>>> --- a/mkfs/f2fs_format.c
>>> +++ b/mkfs/f2fs_format.c
>>> @@ -37,34 +37,76 @@ struct f2fs_checkpoint *cp;
>>>
>>>  static unsigned int quotatype_bits = 0;
>>>
>>> -const char *media_ext_lists[] = {
>>> -     "jpg",
>>> -     "gif",
>>> -     "png",
>>> +const char *cold_ext_lists[] = {
>>> +     /* video */
>>>       "avi",
>>>       "divx",
>>> -     "mp4",
>>> -     "mp3",
>>> -     "3gp",
>>> -     "wmv",
>>> -     "wma",
>>> -     "mpeg",
>>> +     "flv",
>>> +     "m2ts",
>>> +     "m4p",
>>> +     "m4v",
>>>       "mkv",
>>>       "mov",
>>> -     "asx",
>>> -     "asf",
>>> -     "wmx",
>>> -     "svi",
>>> -     "wvx",
>>> -     "wm",
>>> +     "mp4",
>>> +     "mpeg",
>>> +     "mpeg4",
>>>       "mpg",
>>> -     "mpe",
>>> -     "rm",
>>>       "ogg",
>>> +     "ogm",
>>> +     "ogv",
>>> +     "ts",
>>> +     "vob",
>>> +     "wmb",
>>> +     "wmv",
>>> +     "webm",
>>> +
>>> +     /* audio */
>>> +     "aac",
>>> +     "ac3",
>>> +     "dts",
>>> +     "flac",
>>> +     "m4a",
>>> +     "mka",
>>> +     "mp3",
>>> +     "oga",
>>> +     "wav",
>>> +     "wma",
>>> +
>>> +     /* image */
>>> +     "bmp",
>>> +     "gif",
>>> +     "jpg",
>>>       "jpeg",
>>> -     "video",
>>> -     "apk",  /* for android system */
>>> -     "so",   /* for android system */
>>> +     "png",
>>> +     "svg",
>>> +     "webp",
>>> +
>>> +     /* archive */
>>> +     "7z",
>>> +     "a",
>>> +     "deb",
>>> +     "gz",
>>> +     "gzip",
>>> +     "iso",
>>> +     "jar",
>>> +     "lzma",
>>> +     "rar",
>>> +     "tgz",
>>> +     "txz",
>>> +     "udf",
>>> +     "xz",
>>> +
>>> +     /* other */
>>> +     "pdf",
>>> +     "ttf",
>>> +     "ttc",
>>> +
>>> +     /* android */
>>> +     "apk",
>>> +     "exo", // YouTube
>>> +     "odex", // Android RunTime
>>> +     "vdex", // Android RunTime
>>> +     "so",
>>>       NULL
>>>  };
>>>
>>> @@ -74,7 +116,7 @@ const char *hot_ext_lists[] = {
>>>  };
>>>
>>>  const char **default_ext_list[] = {
>>> -     media_ext_lists,
>>> +     cold_ext_lists,
>>>       hot_ext_lists
>>>  };
>>>
>>>
>>
> 
> .
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to