On 2018/4/5 11:47, Jaegeuk Kim wrote: > On 04/04, Chao Yu wrote: >> If last_zone((total_zones >> 2)) is equal or less than >> next_zone(CURSEG_COLD_NODE), cold data area will be located in the >> same position with hot data, fixes it. > > verify_cur_segs() will rearrage this?
Yes, finally, verify_cur_segs() will make sure there is no redundant segment used by different log headers. But we'd better ensure log initial position is correct at the first time, otherwise, verify_cur_segs() will use sequential allocating to initialize log position, which is not match to our original design. Thanks, > > >> >> Signed-off-by: Chao Yu <yuch...@huawei.com> >> --- >> mkfs/f2fs_format.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c >> index 65692bbe083a..8885f632371d 100644 >> --- a/mkfs/f2fs_format.c >> +++ b/mkfs/f2fs_format.c >> @@ -471,7 +471,7 @@ static int f2fs_prepare_super_block(void) >> c.cur_seg[CURSEG_HOT_DATA] = next_zone(CURSEG_COLD_NODE); >> c.cur_seg[CURSEG_COLD_DATA] = >> max(last_zone((total_zones >> 2)), >> - next_zone(CURSEG_COLD_NODE)); >> + next_zone(CURSEG_HOT_DATA)); >> c.cur_seg[CURSEG_WARM_DATA] = >> max(last_zone((total_zones >> 1)), >> next_zone(CURSEG_COLD_DATA)); >> -- >> 2.15.0.55.gc2ece9dc4de6 > > . > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
