On 07/09, Chao Yu wrote: > On 2018/7/7 5:09, Jaegeuk Kim wrote: > > This fixes to support unaligned dio as buffered writes. > > Should we return -EINVAL as manual of write said: > > EINVAL fd is attached to an object which is unsuitable for writing; or the > file > was opened with the O_DIRECT flag, and either the address > specified in buf, the value specified in count, or the current file offset is > not suitably aligned.
I came from many xfstests failures regarding to direct IO error. It seems other filesystems allow buffered writes as well. > > Thanks, > > > > > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> > > --- > > fs/f2fs/data.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > > index e66379961804..6e8e78bb64a7 100644 > > --- a/fs/f2fs/data.c > > +++ b/fs/f2fs/data.c > > @@ -2425,7 +2425,7 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, > > struct iov_iter *iter) > > > > err = check_direct_IO(inode, iter, offset); > > if (err) > > - return err; > > + return 0; > > > > if (f2fs_force_buffered_io(inode, rw)) > > return 0; > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
