On 09/18/2018 09:20 PM, Chao Yu wrote:
On 2018/9/18 14:23, Chengguang Xu wrote:
Currently we set default value to options before parsing remount options,
it will cause unexpected change of options which were specified in first
mount.
Can you check below commit? It looks w/o it we may lose default option after
remount.

498c5e9fcd10 ("f2fs: add default mount options to remount")

Hi Chao,

It looks like there was a bug in remount at that time, but I think the fix above is not correct.

from the patch '498c5e9fcd10', I think it was caused by clearing sbi->mount_opt.opt before

parsing. I think remount should not change the options which were specified by user in

previous mount unless user specifies in remount.

Thanks,
Chengguang




_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to