On 2021/5/10 23:51, Jaegeuk Kim wrote:
On 05/10, Chao Yu wrote:
f2fs_get_block() and f2fs_put_dnode() should be called as a pair,
add missing f2fs_put_dnode() in prepare_compress_overwrite().
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Chao Yu <yuch...@huawei.com>
---
fs/f2fs/compress.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index c208563eac28..d5cb0ba9a0e1 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -1088,6 +1088,7 @@ static int prepare_compress_overwrite(struct compress_ctx
*cc,
for (i = cc->cluster_size - 1; i > 0; i--) {
ret = f2fs_get_block(&dn, start_idx + i);
+ f2fs_put_dnode(&dn);
f2fs_reserve_block()
-> need_put = true;
-> f2fs_put_dnode();
Correct, it looks f2fs_vm_page_mkwrite() doesn't need to call
f2fs_put_dnode() as well.
Thanks,
if (ret) {
i = cc->cluster_size;
break;
--
2.29.2
.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
