On 2021/5/10 22:42, Jaegeuk Kim wrote:
In f2fs_fileattr_set(),if (!fa->flags_valid) mask &= FS_COMMON_FL; In this case, we can set supported flags by mask only instead of BUG_ON. /* Flags shared betwen flags/xflags */ (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \ FS_NODUMP_FL | FS_NOATIME_FL | FS_DAX_FL | \ FS_PROJINHERIT_FL) Fixes: 4c5b47997521 ("vfs: add fileattr ops") Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>
Except fixes line issue pointed out by Eric, other part looks good to me. Reviewed-by: Chao Yu <yuch...@huawei.com> Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
