On 2023/4/28 0:21, Jaegeuk Kim wrote:
On 04/27, Chao Yu wrote:
On 2023/4/26 0:47, Yangtao Li wrote:
If a file has FI_COMPRESS_RELEASED, all writes for it should not be
allowed.
Fixes: 5fdb322ff2c2 ("f2fs: add F2FS_IOC_DECOMPRESS_FILE and
F2FS_IOC_COMPRESS_FILE")
Signed-off-by: Qi Han <ha...@vivo.com>
Signed-off-by: Yangtao Li <frank...@vivo.com>
Oh, I just see v2.
Reviewed-by: Chao Yu <c...@kernel.org>
Applied with using goto for code consistency.
It makes sense,
Reviewed-by: Chao Yu <c...@kernel.org>
Thanks,
+ if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
+ err = -EINVAL;
+ goto unlock_out;
+ }
+
/* if in-place-update policy is enabled, don't waste time here */
set_inode_flag(inode, FI_OPU_WRITE);
if (f2fs_should_update_inplace(inode, NULL)) {
@@ -2712,6 +2717,7 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi,
clear_inode_flag(inode, FI_SKIP_WRITES);
out:
clear_inode_flag(inode, FI_OPU_WRITE);
+unlock_out:
inode_unlock(inode);
if (!err)
range->len = (u64)total << PAGE_SHIFT;
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel