Chao Yu <c...@kernel.org> 于2024年7月21日周日 21:32写道： > > On 2024/7/21 21:17, Julian Sun wrote: > > The macro on_f2fs_build_free_nids accepts a parameter nmi, > > but it was not used, rather the variable nm_i was directly used, > > which may be a local variable inside a function that calls the macros. > > > > Signed-off-by: Julian Sun <sunjunchao2...@gmail.com> > > --- > > fs/f2fs/node.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > > index b72ef96f7e33..34eeb2a8598c 100644 > > --- a/fs/f2fs/node.c > > +++ b/fs/f2fs/node.c > > @@ -20,7 +20,7 @@ > > #include "iostat.h" > > #include <trace/events/f2fs.h> > > > > -#define on_f2fs_build_free_nids(nmi) mutex_is_locked(&(nm_i)->build_lock) > > +#define on_f2fs_build_free_nids(nmi) mutex_is_locked(&(nmi)->build_lock) > > > > It's better to use nm_i instead of nmi? > > > > Thanks,
Thanks a lot for your review. Sure. I will send patch v2. > > > > > static struct kmem_cache *nat_entry_slab; > > static struct kmem_cache *free_nid_slab; Best regards, -- Julian Sun <sunjunchao2...@gmail.com> _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
