[f2fs-dev] [PATCH] f2fs: fix unreleased reader lock on return

[Diogo Jahchan Koike]

fix reader lock unreleased in error path.

Fixes: 374a8881ce4c ("f2fs: atomic: fix to forbid dio in atomic_file")
Reported-by: syzbot+733300ca0a9baca7e...@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=733300ca0a9baca7e245
Signed-off-by: Diogo Jahchan Koike <djahchanko...@gmail.com>
---
 fs/f2fs/file.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 51f6ffd5f4e2..c9eda5dbd11f 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2172,6 +2172,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, 
bool truncate)
        ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX);
        if (ret) {
                f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
+               f2fs_up_write(&fi->i_gc_rwsem[READ]);
                goto out;
        }
 
@@ -2181,6 +2182,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, 
bool truncate)
                pinode = f2fs_iget(inode->i_sb, fi->i_pino);
                if (IS_ERR(pinode)) {
                        f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
+                       f2fs_up_write(&fi->i_gc_rwsem[READ]);
                        ret = PTR_ERR(pinode);
                        goto out;
                }
@@ -2189,6 +2191,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, 
bool truncate)
                iput(pinode);
                if (ret) {
                        f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
+                       f2fs_up_write(&fi->i_gc_rwsem[READ]);
                        goto out;
                }
 
@@ -2202,6 +2205,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, 
bool truncate)
                ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true);
                if (ret) {
                        f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
+                       f2fs_up_write(&fi->i_gc_rwsem[READ]);
                        goto out;
                }
        }
-- 
2.39.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel