[f2fs-dev] [PATCH v2 2/2] f2fs: cleanup F2FS_I_SB in f2fs_setattr()

[wangzijie]

After introduce sbi in f2fs_setattr(), cleanup F2FS_I_SB. No logic change.

Signed-off-by: wangzijie <wangzij...@honor.com>
---
 fs/f2fs/file.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 09be6e849..3e610db59 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1029,7 +1029,7 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry 
*dentry,
        struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
        int err;
 
-       if (unlikely(f2fs_cp_error(F2FS_I_SB(inode))))
+       if (unlikely(f2fs_cp_error(sbi)))
                return -EIO;
 
        if (unlikely(IS_IMMUTABLE(inode)))
@@ -1080,12 +1080,11 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry 
*dentry,
        }
        if (i_uid_needs_update(idmap, attr, inode) ||
            i_gid_needs_update(idmap, attr, inode)) {
-               f2fs_lock_op(F2FS_I_SB(inode));
+               f2fs_lock_op(sbi);
                err = dquot_transfer(idmap, inode, attr);
                if (err) {
-                       set_sbi_flag(F2FS_I_SB(inode),
-                                       SBI_QUOTA_NEED_REPAIR);
-                       f2fs_unlock_op(F2FS_I_SB(inode));
+                       set_sbi_flag(sbi, SBI_QUOTA_NEED_REPAIR);
+                       f2fs_unlock_op(sbi);
                        return err;
                }
                /*
@@ -1095,7 +1094,7 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry 
*dentry,
                i_uid_update(idmap, attr, inode);
                i_gid_update(idmap, attr, inode);
                f2fs_mark_inode_dirty_sync(inode, true);
-               f2fs_unlock_op(F2FS_I_SB(inode));
+               f2fs_unlock_op(sbi);
        }
 
        if (attr->ia_valid & ATTR_SIZE) {
@@ -1156,7 +1155,7 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry 
*dentry,
        f2fs_mark_inode_dirty_sync(inode, true);
 
        /* inode change will produce dirty node pages flushed by checkpoint */
-       f2fs_balance_fs(F2FS_I_SB(inode), true);
+       f2fs_balance_fs(sbi, true);
 
        return err;
 }
-- 
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel