[f2fs-dev] [PATCH 22/60] f2fs: Pass a folio to set_cold_node()

[Matthew Wilcox (Oracle)]

All callers have a folio so pass it in.  Also mark it as const to help
the compiler.

Signed-off-by: Matthew Wilcox (Oracle) <wi...@infradead.org>
---
 fs/f2fs/inode.c | 2 +-
 fs/f2fs/node.c  | 4 ++--
 fs/f2fs/node.h  | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index 61fd96f0a1ff..9b71e3e4f635 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -484,7 +484,7 @@ static int do_read_inode(struct inode *inode)
        /* try to recover cold bit for non-dir inode */
        if (!S_ISDIR(inode->i_mode) && !is_cold_node(&node_folio->page)) {
                f2fs_folio_wait_writeback(node_folio, NODE, true, true);
-               set_cold_node(&node_folio->page, false);
+               set_cold_node(node_folio, false);
                folio_mark_dirty(node_folio);
        }
 
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index c733cf6daa2f..15a024581014 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1381,7 +1381,7 @@ struct folio *f2fs_new_node_folio(struct dnode_of_data 
*dn, unsigned int ofs)
 
        f2fs_folio_wait_writeback(folio, NODE, true, true);
        fill_node_footer(&folio->page, dn->nid, dn->inode->i_ino, ofs, true);
-       set_cold_node(&folio->page, S_ISDIR(dn->inode->i_mode));
+       set_cold_node(folio, S_ISDIR(dn->inode->i_mode));
        if (!folio_test_uptodate(folio))
                folio_mark_uptodate(folio);
        if (folio_mark_dirty(folio))
@@ -2828,7 +2828,7 @@ int f2fs_recover_inode_page(struct f2fs_sb_info *sbi, 
struct folio *folio)
        if (!folio_test_uptodate(ifolio))
                folio_mark_uptodate(ifolio);
        fill_node_footer(&ifolio->page, ino, ino, 0, true);
-       set_cold_node(&ifolio->page, false);
+       set_cold_node(ifolio, false);
 
        src = F2FS_INODE(folio);
        dst = F2FS_INODE(ifolio);
diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
index bf6d6fab0c78..d1c15fc0ddd8 100644
--- a/fs/f2fs/node.h
+++ b/fs/f2fs/node.h
@@ -406,9 +406,9 @@ static inline int is_node(const struct page *page, int type)
 #define is_fsync_dnode(page)   is_node(page, FSYNC_BIT_SHIFT)
 #define is_dent_dnode(page)    is_node(page, DENT_BIT_SHIFT)
 
-static inline void set_cold_node(struct page *page, bool is_dir)
+static inline void set_cold_node(const struct folio *folio, bool is_dir)
 {
-       struct f2fs_node *rn = F2FS_NODE(page);
+       struct f2fs_node *rn = F2FS_NODE(&folio->page);
        unsigned int flag = le32_to_cpu(rn->footer.flag);
 
        if (is_dir)
-- 
2.47.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel