On Mon, Aug 11, 2025 at 05:44:13PM +0800, Chao Yu wrote: > This is a regression testcase, it is added to check below case > and its variants: > - write 16k data into compressed file (data will be compressed) > - truncate file to 12k (truncate partial data in compressed cluster) > - truncate file to 20k > - verify data in range of [12k, 16k] to see whether data is all zero > or not > > Cc: Jaegeuk Kim <[email protected]> > Signed-off-by: Chao Yu <[email protected]> > --- > tests/f2fs/018 | 58 ++++++++++++++++++++++++++++++++++++++++++++++ > tests/f2fs/018.out | 2 ++ > 2 files changed, 60 insertions(+) > create mode 100755 tests/f2fs/018 > create mode 100644 tests/f2fs/018.out > > diff --git a/tests/f2fs/018 b/tests/f2fs/018 > new file mode 100755 > index 00000000..ca727d24 > --- /dev/null > +++ b/tests/f2fs/018 > @@ -0,0 +1,58 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2025 Chao Yu. All Rights Reserved. > +# > +# FS QA Test No. f2fs/018 > +# > +# This is a regression test to check whether page eof will be > +# zero or not after we truncate partial data in compressed > +# cluster. > +# > +. ./common/preamble > +_begin_fstest auto quick rw compress > + > +_fixed_by_kernel_commit ba8dac350faf \ > + "f2fs: fix to zero post-eof page" > +_fixed_by_kernel_commit xxxxxxxxxxxx \ > + "f2fs: fix to zero data after EOF for compressed file correctly" > + > +_require_scratch > +_require_fio > + > +testfile=$SCRATCH_MNT/testfile > + > +check_data_eof() > +{ > + local eof_start=$1 > + local eof_size=$2 > + local filesize=$3 > + local offset1=$4 > + local offset2=$5 > + local offset3=$6 > + > + _scratch_mkfs "-O extra_attr,compression" >> $seqres.full || _fail > "mkfs failed" > + _scratch_mount "-o compress_extension=*" >> $seqres.full > + > + xfs_io -f -c "pwrite 0 $filesize" -c "fsync" $testfile >> $seqres.full > + xfs_io -c "truncate $offset1" $testfile > + xfs_io -c "truncate $offset2" $testfile
replace "xfs_io" with "$XFS_IO_PROG" > + > + if [ "$offset3" ]; then > + xfs_io -c "truncate $offset3" $testfile Same as above. And generally we need: _require_xfs_io_command "truncate" > + fi > + > + $FIO_PROG --name=verify-data --filename=$testfile --rw=read > --verify=pattern \ > + --verify_pattern=0x00 --do_verify=1 --verify_only > --offset=$eof_start \ > + --size=$eof_size >> $seqres.full 2>&1 || _fail "eof data is not > zero" Generally we do `_require_fio $fio_config` to make sure all arguments are supported by current fio version and FSTYP, refer to generic/366. But as this is a f2fs only test, and if you make sure you don't use any new/special fio arguments, I can accept this. Or you can refer to generic/366. > + _scratch_unmount I'm not familar with f2fs much, may I ask why we need to mkfs&mount ... umount in each test loop? Thanks, Zorro > +} > + > +check_data_eof 12k 4k 16k 12k 20k > +check_data_eof 10k 6k 16k 10k 20k > +check_data_eof 12k 4k 16k 8k 12k 20k > +check_data_eof 10k 6k 16k 8k 10k 20k > + > +echo "Silence is golden" > + > +status=0 > +exit > diff --git a/tests/f2fs/018.out b/tests/f2fs/018.out > new file mode 100644 > index 00000000..8849e303 > --- /dev/null > +++ b/tests/f2fs/018.out > @@ -0,0 +1,2 @@ > +QA output created by 018 > +Silence is golden > -- > 2.49.0 > _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
