On Thu, Dec 18, 2025 at 3:33 PM Christoph Hellwig <[email protected]> wrote: > On Thu, Dec 18, 2025 at 07:17:17AM +0000, Joanne Chang wrote: > > generic/735 attempts to create a file with nearly 2^32 blocks. However, > > the maximum block count per file in F2FS is limited by the capacity of > > the inode. This limit is roughly 2^30 blocks, which is significantly > > lower than the test's requirement. > > > > Signed-off-by: Joanne Chang <[email protected]> > > --- > > tests/generic/735 | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/tests/generic/735 b/tests/generic/735 > > index 9bbdf3a1..d5ba5673 100755 > > --- a/tests/generic/735 > > +++ b/tests/generic/735 > > @@ -19,6 +19,9 @@ if [[ "$FSTYP" =~ ext[0-9]+ ]]; then > > _fixed_by_kernel_commit 2dcf5fde6dff "ext4: prevent the normalized > > size from exceeding EXT_MAX_BLOCKS" > > fi > > > > +# Block number 0xffffffff is too big for a file in f2fs. > > +_exclude_fs f2fs > > Please don't add random file system excludes. This should be > abstracted into a _require_max_file_size helper or similar.
Thank you for the feedback. I will implement a _require_blocks_in_file helper in the next version. As far as I know, there isn't a generic way to query the block number limit across filesystems, so I plan to hardcode the known limit for F2FS within the helper for now. Please let me know if you have any further suggestions. Best regards, Joanne _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
