[...] > > well, wouldn't even ls $cfdir/package_config/*.asc do the trick? To be > > honest, I don't know what the best place for keeping those files would be. > > Hmm, no, your code seems to assume that those files are in $cfdir directly, > > otherwise the sed command would break it!? I'm slightly confused. > > > This is a patch to make-fai-nfsroot, thus the $cfdir is doesn't necessarily > include /package_config/ I'm pretty sure. I am reasonably sure that I'd want > to keep the key file someplace that makes sense for the make-fai-nfsroot and > my sense was that because /package_config/ doesn't necessarily even have to > exist for make-fai-nfsroot to run successfully it wouldn't have been the best > place. I thought that /etc/fai/ or even better, etc/fai/apt would be more > appropriate and that $cfdir was the expression of that within the script. >
Oh, right, sorry, I had completely missed that $cfdir wasn't actually a config space. So my only concern that remains is: wouldn't the sed command possibly remove too much of the string? > > > - Maybe the most important change would therefore be a comment about the > > location of those files *and* documentation in the man page. > > > I'll be sure to add a comment. I don't know how to go about submitting a > change to a man page. Is it just a patch too? This is pretty new to me, yet. > Yes, after all a man page has a plain text source as well. Just provide some patch and I'll try to merge that into experimental ASAP. > > - Why copy the file? AFAIK there is no need to store it, > > "cat $cfdir/$f | $ROOTCMD apt-key add -" should do as well. > I chose to copy the file so that some time in the future, should the question > arise, I'll be able to answer the inevitable "how did that key get there?" > I'm an old guy, I tend to forget things and I code in such a way as to leave > myself hints. I'd be perfectly happy to not do that, and use your > recommendation, however. > Hmm, good point, but I wouldn't have read it like this. Therefore, what about placing them in a directory that carries additional information, like /etc/apt/keys-added-by-m-f-n/ ? Because otherwise myself I likely couldn't tell how the keys found their way into /etc/apt :-) Thanks for all the work and sorry for making such a fuss about a little intrusive patch while my changes keep breaking your systems... Best regards, Michael
pgpyAo7jinzbG.pgp
Description: PGP signature
