Hello.
> On Sep 29, 6:01pm, Jan Kara wrote:
> > Subject: Fixes in quota (fwd)
> >
> > Hello.
> >
> > So I did the fixes of races in quota Al found. The patch can
> > be found at
>ftp://atrey.karlin.mff.cuni.cz/pub/local/jack/quota/v2.4/quota-fix-2.4.0-test8-1.diff.
> > In the patch are included also some cleanups (especially change in
> > invalidate_dquots()) which I originally wanted to leave for 2.5 but they
> > simplified fixing of races a lot. The patch seems to work for me but
> > I didn't test it heavily.
> > I'd be grateful if anybody else tried the patch too. It shouldn't eat
> > your data but oopses are possible...
> >
>
> I'm running a test8 + xfs + your patch kernel. I saw two compiler
> warnings (egcs-2.91.66) when building...
>
> (fs/nfsd/)
> vfs.c: In function `nfsd_setattr':
> vfs.c:303: warning: passing arg 1 of `DQUOT_TRANSFER' from incompatible pointer
>
> looks nasty - should be...
> 303c303
> < err = DQUOT_TRANSFER(dentry, iap);
> ---
> > err = DQUOT_TRANSFER(inode, iap);
>
> dquot.c: In function `print_warning':
> dquot.c:802: warning: passing arg 2 of `tty_write_message' discards `const' from
>
> nothing major here - either need to change printk.c to take a
> const, or cast...
> 802c802
> < tty_write_message(current->tty, bdevname(dquot->dq_sb->s_dev));
> ---
> > tty_write_message(current->tty, (char *)bdevname(dquot->dq_sb->s_dev));
I made new version of my quota-fix. NFSD and also other filesystems
like UFS, UDF are fixed. I also fixed MINIX. I know Al is removing quota support
from it so this is just temporary for MINIX to at least compile just with my
patch.
You can download the patch at:
ftp://atrey.karlin.mff.cuni.cz/pub/local/jack/quota/v2.4/quota-fix-2.4.0-test8-2.diff
Honza
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]