>>>>> " " == Alexander Viro <[EMAIL PROTECTED]> writes:

     > On Mon, 25 Jun 2001, Trond Myklebust wrote:

    >> As I said, the patch looks good, and the races are gone.  The
    >> only question I have is about the above section in
    >> nfs_fhget(). AFAICS the NFS_CACHEINV() you've inserted here
    >> will get clobbered by the nfs_refresh_inode() below it.

     > Erm... Sorry - the thing got moved in there from
     > nfs_read_inode(). Along with the old contents of
     > nfs_fill_inode(). I've collapsed obviously redundant stuff, but
     > I might easily miss some.

Oops. I've missed some of my own then...

     > Fine. I've moved call of nfs_refresh_inode() into both
     > branches, expanded it in the "got the new inode, need to fill
     > it" one and removed the redundant stuff there.

     > Another thing: init_nfs_fs() doesn't clean up after itself in
     > case of failure.  Fixed.

     > Here's the patch (incremental to previous):

Great. As far as I'm concerned it's ready for Linus.

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]

Reply via email to