At 5:16 PM +0100 2001-06-15, Matthew Wilcox wrote:
>I think this could be clearer.
>
>       struct list_head *tmp;
>restart:
>       spin_lock(&sb_lock);
>       list_for_each(tmp, super_blocks) {
>               struct super_block *sb = sb_entry(tmp);
>               if (!sb->s_dirt)
>                       continue;
>               spin_unlock(&sb_lock);
>               down_read(&sb->s_umount);
>               write_super(sb);
>               drop_super(sb);
>               goto restart;
>       }
>       spin_unlock(&sb_lock);

A minor improvement, IMO, is:

        struct list_head *tmp;
restart:
        spin_lock(&sb_lock);
        list_for_each(tmp, super_blocks) {
                struct super_block *sb = sb_entry(tmp);
                if (sb->s_dirt) {
                        sb->s_count++;
                        spin_unlock(&sb_lock);
                        down_read(&sb->s_umount);
                        write_super(sb);
                        drop_super(sb);
                        goto restart;
                }
        }
        spin_unlock(&sb_lock);

-- 
/Jonathan Lundell.
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]

Reply via email to