On Fri, 2005-07-08 at 15:34 +0200, Roman Zippel wrote: > Are the advantages big enough to actively discourage defines? It's nice > that you do reviews, but please leave some room for personal preferences. > If the code is correct and perfectly readable, it doesn't matter whether > to use defines or enums. Unless you also intent to also debug and work > with that code, why don't leave the decision to the author?
I think the advantages are big enough. Also, in my experience, it is usually not a conscious decision by the author. But if you and other developers think my enum pushing is too much, I can tone it down :). Pekka - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html