On Tue 01-05-07 20:26:27, Greg KH wrote:
> On Mon, Apr 30, 2007 at 07:55:36PM +0200, Jan Kara wrote:
> > Hello,
> >
> > attached patch implements renaming for debugfs. I was asked for this
> > feature by WLAN guys and I guess it makes sence (they have some debug info
> > in the directory identified by interface name and that can change...).
> > Could someone have a look at what I wrote whether it looks reasonable?
> > Thanks.
> >
> > Honza
> >
> > --
> > Jan Kara <[EMAIL PROTECTED]>
> > SuSE CR Labs
>
> > Implement debugfs_rename() to allow renaming files/directories in debugfs.
>
> I think you are going to need more infrastructure here, the caller
> doesn't want to have to allocate a new dentry themselves, they just want
> to pass in the new filename :)
Actually, I wanted the call to be in the spirit of other debugfs calls.
So we have for example:
void debugfs_remove(struct dentry *dentry)
struct dentry *debugfs_create_dir(const char *name, struct dentry *parent)
etc.
So it seemed to me that the interface with dentries was perfectly
appropriate... One possibility would be to take filename of a file to
rename instead of old_dentry. But dirs should IMHO remain to be dentries...
Honza
--
Jan Kara <[EMAIL PROTECTED]>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
