On Sep 19, 2007 12:15 -0700, Mingming Cao wrote: > @@ -96,8 +96,7 @@ static int start_this_handle(journal_t * > > alloc_transaction: > if (!journal->j_running_transaction) { > - new_transaction = kmalloc(sizeof(*new_transaction), > - GFP_NOFS|__GFP_NOFAIL); > + new_transaction = kmalloc(sizeof(*new_transaction), GFP_NOFS);
This should probably be a __GFP_NOFAIL if we are trying to start a new handle in truncate, as there is no way to propagate an error to the caller. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html