> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 0079b2c..d8fb795 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
...
> +
> +     raw_inode = ext2_get_inode(inode->i_sb, ino, &bh);
>       if (IS_ERR(raw_inode))
>               goto bad_inode;
  Hmm, why don't you use the return value from raw_inode? It can be
either -EIO or -EINVAL if 'ino' was invalid...
  Otherwise the patch looks fine.

                                                                Honza
-- 
Jan Kara <[EMAIL PROTECTED]>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to