On Jan 23, 2008 4:00 AM, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > Hi, > > > This touches so many different places that I did not feel like creating > a miniscule patch for each architecture. I hope that is ok. > > ===Patch begins=== > [PATCH] procfs: constify function pointer tables > > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> > --- > arch/alpha/kernel/setup.c | 2 +- > arch/blackfin/kernel/setup.c | 2 +- > arch/cris/kernel/setup.c | 2 +- > arch/frv/kernel/setup.c | 2 +- > arch/h8300/kernel/setup.c | 2 +- > arch/m32r/kernel/setup.c | 2 +- > arch/m68k/kernel/setup.c | 2 +- > arch/m68knommu/kernel/setup.c | 2 +- > arch/parisc/kernel/setup.c | 2 +- > arch/ppc/kernel/setup.c | 2 +- > arch/v850/kernel/procfs.c | 2 +- > arch/xtensa/kernel/setup.c | 2 +- > fs/proc/base.c | 6 +++--- > fs/proc/nommu.c | 2 +- > fs/proc/proc_misc.c | 22 +++++++++++----------- > fs/proc/proc_sysctl.c | 4 ++-- > fs/proc/proc_tty.c | 2 +- > fs/proc/task_mmu.c | 8 ++++---- > fs/proc/task_nommu.c | 2 +- > 19 files changed, 35 insertions(+), 35 deletions(-) > > diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c > index bd5e68c..823f18e 100644 > --- a/arch/alpha/kernel/setup.c > +++ b/arch/alpha/kernel/setup.c > @@ -1472,7 +1472,7 @@ c_stop(struct seq_file *f, void *v) > { > } > > -struct seq_operations cpuinfo_op = { > +const struct seq_operations cpuinfo_op = { > .start = c_start, > .next = c_next, > .stop = c_stop, > diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c > index d282201..d67cf54 100644 > --- a/arch/blackfin/kernel/setup.c > +++ b/arch/blackfin/kernel/setup.c > @@ -691,7 +691,7 @@ static void c_stop(struct seq_file *m, void *v) > { > } > > -struct seq_operations cpuinfo_op = { > +const struct seq_operations cpuinfo_op = { > .start = c_start, > .next = c_next, > .stop = c_stop,
Thanks, I understand the seq_xxx() API needs "const struct seq_operations *". So for Blackfin part, I agree with Mike. Acked-by: Bryan Wu <[EMAIL PROTECTED]> but there are still some other files need add "const": --- /opt/git-tree/blackfin-2.6$ grep -r seq_operations arch/* arch/alpha/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/arm/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/arm/mach-davinci/clock.c:static struct seq_operations davinci_ck_op = { arch/avr32/kernel/cpu.c:struct seq_operations cpuinfo_op = { arch/avr32/mm/tlb.c:static struct seq_operations tlb_ops = { arch/blackfin/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/cris/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/frv/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/h8300/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/ia64/hp/common/sba_iommu.c:static struct seq_operations ioc_seq_ops = { arch/ia64/kernel/perfmon.c:struct seq_operations pfm_seq_ops = { arch/ia64/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/ia64/sn/kernel/sn2/sn2_smp.c:static struct seq_operations sn2_ptc_seq_ops = { arch/ia64/sn/kernel/sn2/sn_hwperf.c:static struct seq_operations sn_topology_seq_ops = { arch/m32r/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/m68k/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/m68knommu/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/mips/kernel/proc.c:struct seq_operations cpuinfo_op = { arch/parisc/kernel/setup.c:struct seq_operations cpuinfo_op = { arch/powerpc/kernel/setup-common.c:struct seq_operations cpuinfo_op = { ---- [!snip!] Regards, -Bryan - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html