> Hi
>
Sorry for self-followup but some substantial news are known:
> Version: Linus kernel 2.2.12+Alan prepatch 2.2.13pre12+some knfsd 1.5.1 diffs
> BEWARE: I was returning value 1 before and consequently ext2 bitmap errors
> occured at our server which were never seen before - it had yet to be
> investigated whether it has been caused by this patch but you have been warned
> (about returning 1). Returning 1 had visible impact only on reducing the count
> of "parachuting" messages but evidently the returned result was much more
> pervasive than expected.
OK, it was proofed that those "ext2" bitmap errors couldn't be caused by this
patch (no message occurence found in logs) so it is considered safe, these
errors were caused by Alan-13pre12 (!). Further - value 0 as in the previous
patch was in fact causing serious problems after CTRL-C on Sun machine so it
wasn't solving much. Returning 1 is the correct way AFAI-currently-K. We are
using now clean Linus-12 without prepatches and this patch.
Thanks for Linux support,
Karel Zatloukal
Updated patch, "return 1" -> "return 0".
--- linux/fs/nfsd/nfsxdr.c-orig Sun Sep 26 23:31:53 1999
+++ linux/fs/nfsd/nfsxdr.c Sun Sep 26 19:07:09 1999
@@ -364,6 +364,10 @@
nfssvc_encode_attrstat(struct svc_rqst *rqstp, u32 *p,
struct nfsd_attrstat *resp)
{
+ if (!resp->fh.fh_dentry) {
+ printk(KERN_WARNING "nfsd: nfssvc_encode_attrstat() parachuting!\n");
+ return 1;
+ }
if (!(p = encode_fattr(rqstp, p, resp->fh.fh_dentry->d_inode)))
return 0;
return xdr_ressize_check(rqstp, p);
