Re: [patch] [possible race in ext2] Re: how to write get_block?

[Mikulas Patocka]

On Sat, 9 Oct 1999, Andrea Arcangeli wrote:

> On Fri, 8 Oct 1999, Mikulas Patocka wrote:
> 
> >Here goes quick'n'dirty patch. It does bforget(). It should prevent file
> >corruption.
> 
> wrong patch. bforget give you no guarantee at all. bfoget always fallback
> to brelse if necessary.
> 
> What I said about bforget in my old email is still true. The _only_ reason
> for using bforget instead of brelse is to get buffer performances (that in
> 2.3.x are not so interesting as in 2.2.x as in 2.3.x flushpage is just
> doing the interesting stuff with the real data).

Yes, there is race when bforget is called while buffer is being flushed.
mark_buffer_clean();wait_on_buffer(); should be used.

Mikulas Patocka