On Wed, 15 Dec 1999, Oliver Neukum wrote:

> Hi,
> 
> in minixfs the suid bit is not removed, if a file is written to by an ordinary
> user. I took the code in question from ext2.

Don't *wham* duplicate *wham* code for no good reasons *wham**wham**wham*

Sorry, but it's Wrong Thing(tm). Correct place is _not_ in per-fs
functions. For 2.3 it's generic_file_write(), for 2.2 - sys_write() and
sys_pwrite() (_only_ after you know that call will happen, indeed).
I'll do 2.3 stuff - actually already done, but there will be more in the
same patch, so wait until tomorrow. Please, do 2.2 but do it _right_.

Reply via email to