On Fri, Aug 16, 2013 at 08:28:08PM +0200, Linus Walleij wrote: > On Fri, Aug 16, 2013 at 8:20 PM, Mark Brown <[email protected]> wrote:
> > It's common to have inline wrappers for the regmap ops which take the > > device specific struct and fish the regmap pointer out of it. > I had no clue ... hm this is another side effect of not getting the > whole patch set I guess. Yeah. I think from a subsystem point of view it's probably best to just not worry about this sort of functions and just assume it'll get caught in the review of the MFD driver. If there's regmap helpers for the subsystem it's a bit different of course. > Hmmm I've been irritated about the "v" in "virq" because these > interrupt numbers are and have always been Linux interrupt > numbers, that they sometimes, on some systems, for the low > IRQs, correspond to the hardware IRQ numbers is pure pattern > matching and luck. > They are no more "virtual" than any other IRQ numbers in the > kernel. They are all "virtual" in a sense. > Well nevermind that, it's probably just another try at tilting > windmills to get it changed anyway. Yeah, I agree with you there. If I'd seen irqdomain when I wrote the function I'd probably have called it _create_mapping() but as it was I wanted to distinguish which of the IRQ number spaces was being looked up in. Possibly more trouble than it's worth to do the rename now though.
signature.asc
Description: Digital signature
