On Tue, Sep 3, 2013 at 5:27 PM, Fabio Estevam <[email protected]> wrote:
> Hi Linus,
>
> I am running linux-next 20130903 and I noticed that:
>
> commit 8fea68f4987e50d31205da8bd88fd41fe3962355
> Author: Linus Walleij <[email protected]>
> Date: Fri Aug 30 09:41:45 2013 +0200
>
> gpio: improve error path in gpiolib
>
> , causes imx6q-sabresd board to hang:
>
> ci_hdrc ci_hdrc.0: doesn't support gadget
> ci_hdrc ci_hdrc.0: EHCI Host Controller
> ci_hdrc ci_hdrc.0: new USB bus registered, assigned bus number 1
> ci_hdrc ci_hdrc.0: USB 2.0 started, EHCI 1.00
> hub 1-0:1.0: USB hub found
> hub 1-0:1.0: 1 port detected
> ci_hdrc ci_hdrc.1: doesn't support gadget
> ci_hdrc ci_hdrc.1: EHCI Host Controller
> ci_hdrc ci_hdrc.1: new USB bus registered, assigned bus number 2
> ci_hdrc ci_hdrc.1: USB 2.0 started, EHCI 1.00
> hub 2-0:1.0: USB hub found
> hub 2-0:1.0: 1 port detected
> gpiod_set_debounce: missing set() or set_debounce() operations
>
> If I revert this commit, then I am able to boot correctly.
I think I found a fix:
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1783,7 +1783,7 @@ static int gpiod_set_debounce(struct gpio_desc *desc, unsi
if (!chip->set || !chip->set_debounce) {
pr_warn("%s: missing set() or set_debounce() operations\n",
__func__);
- return -EIO;
+ goto fail;
}
will submit it shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
