On Tue, Sep 3, 2013 at 2:15 PM, Dan Carpenter <[email protected]> wrote:
> There is a missing unlock on error here. > > Signed-off-by: Dan Carpenter <[email protected]> > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 0eb9cba..3c01782 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -1783,7 +1783,8 @@ static int gpiod_set_debounce(struct gpio_desc *desc, > unsigned debounce) > if (!chip->set || !chip->set_debounce) { > pr_warn("%s: missing set() or set_debounce() operations\n", > __func__); > - return -EIO; > + status = -EIO; > + goto fail; > } Yeah I screwed up. I queued another fix though, moving the locking below the check instead. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
