Linus Walleij <[email protected]> writes: > +++ b/drivers/staging/media/lirc/lirc_serial.c > @@ -839,6 +839,16 @@ static int lirc_serial_probe(struct platform_device *dev) > { > int i, nlow, nhigh, result; > > +#ifdef CONFIG_LIRC_SERIAL_NSLU2 > + /* This GPIO is used for a LED on the NSLU2 */ > + result = devm_gpio_request(dev, NSLU2_LED_GRN, "lirc-serial");
Will this succeed with the LED driver already loaded? Should the user unload it first? Otherwise, while I don't have any of the hw in question, I can't see other obvious problems, so for the whole patchset: Acked-by: Krzysztof Halasa <[email protected]> -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
