On Thu, Nov 28, 2013 at 03:45:37PM +0100, Linus Walleij wrote: > On Thu, Nov 28, 2013 at 9:46 AM, Alexandre Courbot <acour...@nvidia.com> > wrote: > > > Change the format of the platform GPIO lookup tables to make them less > > confusing and improve lookup efficiency. > > > > The previous format was a single linked-list that required to compare > > the device name and function ID of every single GPIO defined for each > > lookup. Switch that to a list of per-device tables, so that the lookup > > can be done in two steps, omitting the GPIOs that are not relevant for a > > particular device. > > > > The matching rules are now defined as follows: > > - The device name must match *exactly*, and can be NULL for GPIOs not > > assigned to a particular device, > > - If the function ID in the lookup table is NULL, the con_id argument of > > gpiod_get() will not be used for lookup. However, if it is defined, it > > must match exactly. > > - The index must always match. > > > > Signed-off-by: Alexandre Courbot <acour...@nvidia.com> > > --- > > Let's change this bad design before more users start using it. ;) > > OK given that Mika has based his patches on this I'll request > that he ACK this and then I'll merge this so that he can put > this patch at the bottom of his patch stack. > > Mika: requesting ACK.
Alexandre, please check Andy's comments. Apart from that this looks good to me. Acked-by: Mika Westerberg <mika.westerb...@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
