On Thu, Jan 2, 2014 at 1:18 PM, Baruch Siach <[email protected]> wrote: > On Thu, Jan 02, 2014 at 01:07:24PM +0100, Linus Walleij wrote: >> On Mon, Dec 16, 2013 at 8:05 AM, Baruch Siach <[email protected]> wrote: >> >> > Prevent build failure when the selected variant does not support GPIO32. >> > >> > Signed-off-by: Baruch Siach <[email protected]> >> (...) >> > +config HAVE_XTENSA_GPIO32 >> > + bool >> > + >> > config GPIO_XTENSA >> > bool "Xtensa GPIO32 support" >> > depends on XTENSA >> > + depends on HAVE_XTENSA_GPIO32 >> >> This is just a tautology, you don't need a helper bool >> for this. >> >> Instead just select GPIO_XTENSA from your affected >> platforms. > > But then you force this driver on all users. Why not leave the option to > disable this driver when the user needs direct access to this hardware, or > just wants to remove unused code?
Hmm you're right. But if the build fails on !XTENSA, can you not put a depends on XTENSA_VARIANT_FSF || XTENSA_VARIANT_DC232B || XTENSA_VARIANT_DC233C Into drivers/gpio/Kconfig? It's a simple oneliner... Usually the only reason not to do this would be to get a wider compile coverage but the patch says it only compiles on these platforms anyway :-P Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
