On Wed, Jan 22, 2014 at 4:05 PM, Lars Poeschel <[email protected]> wrote:
> After I read Torvalds mail, I
> realized that mcp23s08 driver now depends on OF_GPIO. I wonder if your patch
> was the best way to fix this.
I did this:
depends on (SPI_MASTER && !I2C) || I2C && OF_GPIO
But Torvalds realized we have to do it like this:
depends on OF_GPIO
depends on (SPI_MASTER && !I2C) || I2C
Due to some funny business in Kconfig.
> I think a better way would be to not explicitly
> depend on OF_GPIO rather than disabling interrupt functionality if OF_GPIO is
> not selected. What I am a bit concerned about is, that we locked out non-OF
> users from being able to use this driver from now on.
OK you need to think of something, if it's not causing any regressions
on some board it's no problem.
So user stories are needed to justify this as a regression fix.
> I seems since Linus Torvalds now pulled our patches and fixed them up, it is a
> bit too late, but should we do another patch third patch, that reenables the
> non-OF usage of the driver ? What do you think ?
That will be for the next merge window in that case.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
