On Fri, May 16, 2014 at 8:03 PM, Feng Kan <[email protected]> wrote: > Add gpio dts node for APM X-Gene SoC platform. > > Signed-off-by: Feng Kan <[email protected]> (...) > + gpio: gpio@1701c000 { > + compatible = "apm,xgene-gpio"; > + reg = <0x0 0x1701c000 0x0 0x1000>; > + > + banka: gpio-controller@0 { > + compatible = "apm,xgene-gpio-port"; > + gpio-controller; > + #gpio-cells = <2>; > + ngpios = <16>; > + bank = <0>; > + }; > + bankb: gpio-controller@1 { > + compatible = "apm,xgene-gpio-port"; > + gpio-controller; > + #gpio-cells = <2>; > + ngpios = <16>; > + bank = <1>; > + }; > + bankc: gpio-controller@2 { > + compatible = "apm,xgene-gpio-port"; > + gpio-controller; > + #gpio-cells = <2>; > + ngpios = <16>; > + bank = <2>; > + }; > + };
NAK, please construct this with one gpio per bank and three independent entries instead of sub-banks. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
