Hi (Tovaritsj?) Sergei, Matsuoka-san,
On Wed, Aug 19, 2015 at 12:29 AM, Sergei Shtylyov
<[email protected]> wrote:
> From: Koji Matsuoka <[email protected]>
>
> Add VIN0/1 pin groups to R8A7794 PFC driver.
>
> Signed-off-by: Koji Matsuoka <[email protected]>
> [Sergei: rebased, renamed, added changelog.]
> Signed-off-by: Sergei Shtylyov <[email protected]>
Thanks for your patch!
> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
> @@ -2789,6 +2789,167 @@ static const unsigned int usb1_mux[] = {
> USB1_OVC_MARK,
> };
>
> +union vin_data {
> + unsigned int data24[24];
> + unsigned int data20[20];
> + unsigned int data16[16];
> + unsigned int data12[12];
> + unsigned int data10[10];
> + unsigned int data8[8];
> +};
> +
> +#define VIN_DATA_PIN_GROUP(n, s) \
> + { \
> + .name = #n#s, \
> + .pins = n##_pins.data##s, \
> + .mux = n##_mux.data##s, \
> + .nr_pins = ARRAY_SIZE(n##_pins.data##s), \
> + }
As this is the third occurrence of these 2 definitions, perhaps they
should be moved to sh_pfc.h?
> +/* - VIN1 -----------------------------------------------------------------
> */
> +static const unsigned int vin1_g_b_pins[] = {
> + /* G */
> + RCAR_GP_PIN(1, 10), RCAR_GP_PIN(1, 11),
> + RCAR_GP_PIN(1, 12), RCAR_GP_PIN(1, 13),
> +};
> +static const unsigned int vin1_g_b_mux[] = {
> + /* G */
> + VI1_DATA8_MARK, VI1_DATA9_MARK,
> + VI1_DATA10_MARK, VI1_DATA11_MARK,
> +};
This is the green channel, to augment red and blue in vin_data8*?
If yes, would it make sense to have a separate vin1_data12* section,
combining them?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
