On Thu, Aug 27, 2015 at 8:26 PM, Linus Walleij <[email protected]> wrote:
> The state container of the Zynq GPIO driver is sometimes
> extracted from the gpio_chip exploiting the fact that offsetof()
> the struct gpio_chip inside the struct zynq_gpio is 0, so
> the container_of() is in practice a noop. However if a member
> is added to struct zynq_gpio in front of struct gpio_chip,
> things will break. Using proper container_of() avoids this
> problem.
>
> Semantically this is a noop, the compiler will optimize it away,
> but syntactically it makes me happier.
>
> Also replace some explicit container_of() calls with the helper
> function.
>
> Cc: Harini Katakam <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>
> Cc: Ezra Savard <[email protected]>
> Cc: Michal Simek <[email protected]>
> Signed-off-by: Linus Walleij <[email protected]>

Acked-by: Harini Katakam <[email protected]>

Thanks!

Regards,
Harini
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to