Hi Laurent
> > From: Kuninori Morimoto <[email protected]>
> >
> > This patch adds SCIF0/1/2/3/4/5
> >
> > This patch is including Geert's SCIF support patch
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > Signed-off-by: Kuninori Morimoto <[email protected]>
>
> I won't have time to review this in details. If you and Geert have double-
> checked the data I'll trust you that they're correct.
Thanks. One question
In very pseudo code, PFC driver needs...
1) FN list
2) MARK list
3) register <-> FN mapping
4) pin <-> FN mapping
5) DT interface <-> pin mapping
Previous version had
- almost all (not all) 1), 2) list
- some 3), 4), 5) mapping
-> it needs missing list, and new mapping for new feature
This version is
- [1/2]: frame only, minimum list, minimum mapping
- [2/2]: SCIF necessary list/mapping
-> it needs all necessary FN/MARK list, and necessary mapping for new feature
Good point of new version is it picks up necessary list/mapping/setting.
Bad point of new version is it is very PITA to create/check pin.
which style do you like ?
1) It has all 1) 2) 3) in initial patch
we will add 4) 5) for new feature
2) It has minimum list/mapping only in initial patch
we will add necessary 1) 2) 3) 4) 5) for new feature
I don't know which one is good style, but it is good timing to decide it,
since it can be base style.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
