Hi Morimoto-san, On Thu, Sep 3, 2015 at 10:31 AM, Kuninori Morimoto <[email protected]> wrote: >> > From: Kuninori Morimoto <[email protected]> >> > >> > This patch adds SCIF0/1/2/3/4/5 >> > >> > Original patch was created by Geert, >> > and Kuninori Morimoto updated it >> > >> > Signed-off-by: Geert Uytterhoeven <[email protected]> >> > Signed-off-by: Kuninori Morimoto <[email protected]> >> > Acked-by: Laurent Pinchart <[email protected]> >> > --- >> > v1 -> v2 >> > >> > - Add Laurent Acked-by >> >> Thanks for your update, Morimoto-san! >> >> One quick question from my side: Is it intentional that you have the >> "From: Kuninori Morimoto.." line at the top? >> >> It looks a bit strange to me. Since Geert wrote the patch according to >> your commit message and his Signed-off-by is at the top, shouldn't the >> top line also be "From: Geert Uytterhoeven..."? > > 1st SCIF support patch included only SCIF2, > and Geert sent updated patch series which included bugfix. > And I merged these patches to this patch. > So, I kept my "From". > but I puted Geert on top of Signed-off-by since > non SCIF2 are came from Geert (= big volume) > I'm not sure how to do in this case ...
From: Kuninori Morimoto <[email protected]> This patch adds SCIF0/1/2/3/4/5 Signed-off-by: Kuninori Morimoto <[email protected]> [geert: Added SCIF0/1/3/4/5] Signed-off-by: Geert Uytterhoeven <[email protected]> Acked-by: Laurent Pinchart <[email protected]> Note the SoB order, and the "[...]" part. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
