> > On Wed, 2015-10-28 at 15:29 +0100, Laurent Meunier wrote: > > This removes a needless loop which was catched in pinconf.c. > > I'm not a fan of irregular verbs, but here we are: catched -> caught.
Looks like my lack of skills in English grammar got caught ... > > > > Suggested-by: Andriy Shevchenko <[email protected]> > > Sometimes the broken Evolution uses wrong address. Please add "linux." > part after "@". Also, I prefer to use Andy since it's how I'm known here. > > Otherwise: > > Reviewed-by: Andy Shevchenko <[email protected]> Ok sure - I will add it in the V2 and will also update the previous one Thanks > > Signed-off-by: Laurent Meunier <[email protected]> > > --- > > drivers/pinctrl/pinconf.c | 13 +++++-------- > > 1 file changed, 5 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c > > index 1fc09dc..19af718 100644 > > --- a/drivers/pinctrl/pinconf.c > > +++ b/drivers/pinctrl/pinconf.c > > @@ -414,7 +414,7 @@ static int pinconf_dbg_config_print(struct > > seq_file *s, void *d) > > struct pinctrl_dev *pctldev; > > const struct pinconf_ops *confops = NULL; > > struct dbg_cfg *dbg = &pinconf_dbg_conf; > > - int i, j; > > + int i; > > unsigned long config; > > > > mutex_lock(&pinctrl_maps_mutex); > > @@ -428,13 +428,10 @@ static int pinconf_dbg_config_print(struct > > seq_file *s, void *d) > > if (strcmp(map->name, dbg->state_name)) > > continue; > > > > - for (j = 0; j < map->data.configs.num_configs; j++) > > { > > - if (!strcmp(map->data.configs.group_or_pin, > > - dbg->pin_name)) { > > - /* We found the right pin / state */ > > - found = map; > > - break; > > - } > > + if (!strcmp(map->data.configs.group_or_pin, dbg- > > >pin_name)) { > > + /* We found the right pin */ > > + found = map; > > + break; > > } > > } > > > > -- > Andy Shevchenko <[email protected]> Intel Finland Oy
