On Wed, Nov 11, 2015 at 9:27 PM, LABBE Corentin
<clabbe.montj...@gmail.com> wrote:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later at line 132:
> priv->flags = (uintptr_t) of_id->data;
>
> Reported-by: coverity (CID 1324141)
This is a DT-only driver, hence this cannot happen?
> Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com>
> ---
> drivers/gpio/gpio-74xx-mmio.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c
> index 6ed7c0f..6b18682 100644
> --- a/drivers/gpio/gpio-74xx-mmio.c
> +++ b/drivers/gpio/gpio-74xx-mmio.c
> @@ -113,13 +113,16 @@ static int mmio_74xx_dir_out(struct gpio_chip *gc,
> unsigned int gpio, int val)
>
> static int mmio_74xx_gpio_probe(struct platform_device *pdev)
> {
> - const struct of_device_id *of_id =
> - of_match_device(mmio_74xx_gpio_ids, &pdev->dev);
> + const struct of_device_id *of_id;
> struct mmio_74xx_gpio_priv *priv;
> struct resource *res;
> void __iomem *dat;
> int err;
>
> + of_id = of_match_device(mmio_74xx_gpio_ids, &pdev->dev);
> + if (!of_id)
> + return -ENODEV;
> +
> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> return -ENOMEM;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
