On Wed, Dec 9, 2015 at 5:12 AM, Linus Walleij <[email protected]> wrote: > The separate struct bgpio_chip has been a pain to handle, both > by being confusingly similar in name to struct gpio_chip and > for being contained inside a struct so that struct gpio_chip > is contained in a struct contained in a struct, making several > steps of dereferencing necessary. > > Make things simpler: include the fields directly into > <linux/gpio/driver.h>, #ifdef:ed for CONFIG_GENERIC_GPIO, and > get rid of the <linux/basic_mmio_gpio.h> altogether. Prefix > some of the member variables with bgpio_* and add proper > kerneldoc while we're at it. > > Modify all users to handle the change and use a struct > gpio_chip directly. And while we're at it: replace all > container_of() dereferencing by gpiochip_get_data() and > registering the gpio_chip with gpiochip_add_data(). > > Cc: [email protected] > Cc: Lee Jones <[email protected]> > Cc: Alexander Shiyan <[email protected]> > Cc: Shawn Guo <[email protected]> > Cc: Sascha Hauer <[email protected]> > Cc: Tony Lindgren <[email protected]> > Cc: Kukjin Kim <[email protected]> > Cc: Krzysztof Kozlowski <[email protected]> > Cc: Alexandre Courbot <[email protected]> > Cc: Gregory Fong <[email protected]> > Cc: Brian Norris <[email protected]> > Cc: Florian Fainelli <[email protected]> > Cc: Liviu Dudau <[email protected]> > Cc: Sudeep Holla <[email protected]> > Cc: Lorenzo Pieralisi <[email protected]> > Cc: Nicolas Pitre <[email protected]> > Cc: Olof Johansson <[email protected]> > Cc: Vladimir Zapolskiy <[email protected]> > Cc: Rabin Vincent <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Linus Walleij <[email protected]> > --- > ARM SoC folks and Lee: it would be great if you could > ACK the few lines hitting arch/arm/* and drivers/mfd/* in this > so I can take it through the GPIO tree. > ---
[...] > drivers/gpio/gpio-brcmstb.c | 80 ++++----- For brcmstb: Acked-by: Gregory Fong <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
