As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Paul Parsons <lost.dista...@yahoo.com>
Cc: Lee Jones <lee.jo...@linaro.org>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
ChangeLog v1->v2: fixed a compilation issue, I was hammering
to much on parentheses sorry.
---
 drivers/mfd/asic3.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index a726f01e3b02..927e2c2a9a39 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -502,7 +502,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
                return -EINVAL;
        }
 
-       return asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) & mask;
+       return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
+                 & mask);
 }
 
 static void asic3_gpio_set(struct gpio_chip *chip,
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to