Send Linux-ha-cvs mailing list submissions to
linux-ha-cvs@lists.linux-ha.org
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs
or, via email, send a message with subject or body 'help' to
[EMAIL PROTECTED]
You can reach the person managing the list at
[EMAIL PROTECTED]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Linux-ha-cvs digest..."
Today's Topics:
1. Linux-HA CVS: fencing by alan from
(linux-ha-cvs@lists.linux-ha.org)
----------------------------------------------------------------------
Message: 1
Date: Fri, 18 Aug 2006 14:39:52 -0600 (MDT)
From: linux-ha-cvs@lists.linux-ha.org
Subject: [Linux-ha-cvs] Linux-HA CVS: fencing by alan from
To: [EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
linux-ha CVS committal
Author : alan
Host :
Project : linux-ha
Module : fencing
Dir : linux-ha/fencing/stonithd
Modified Files:
stonithd.c
Log Message:
Bug 1412: Marked source FIXME where bug 1412 occurs
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/fencing/stonithd/stonithd.c,v
retrieving revision 1.100
retrieving revision 1.101
diff -u -3 -r1.100 -r1.101
--- stonithd.c 17 Jul 2006 07:42:41 -0000 1.100
+++ stonithd.c 18 Aug 2006 20:39:51 -0000 1.101
@@ -1,4 +1,4 @@
-/* $Id: stonithd.c,v 1.100 2006/07/17 07:42:41 sunjd Exp $ */
+/* $Id: stonithd.c,v 1.101 2006/08/18 20:39:51 alan Exp $ */
/* File: stonithd.c
* Description: STONITH daemon for node fencing
@@ -1384,6 +1384,11 @@
return TRUE;
}
+ /*
+ * FIXME: ch->farside_pid cannot be relied on.
+ * It only works on Linux -- and then not too reliably - because
+ * of bugs in glibc related to threading.
+ */
signed_client = find_client_by_farpid(client_list, ch->farside_pid);
if (signed_client != NULL) {
if (signed_client->cbch != NULL) {
@@ -1531,6 +1536,11 @@
return TRUE;
}
+ /*
+ * FIXME: ch->farside_pid cannot be relied on.
+ * It only works on Linux -- and then not too reliably - because
+ * of bugs in glibc related to threading.
+ */
stonithd_log2(LOG_DEBUG, "begin to dealing with a api msg %s from "
"a client PID:%d.", api_type, ch->farside_pid);
for (i=0; i<DIMOF(api_msg_to_handlers); i++) {
@@ -1767,10 +1777,15 @@
return ST_FAIL;
}
- /* Check if have signoned */
+ /* Check if have signed on */
if ((client = get_exist_client_by_chan(client_list, ch)) == NULL ) {
stonithd_log(LOG_ERR, "stonithd_node_fence: not signoned yet.");
if ( NULL != (st_op = new_stonith_ops_t(request) )) {
+ /*
+ * FIXME: ch->farside_pid cannot be relied on.
+ * It only works on Linux -- and then not too reliably
+ * - because of bugs in glibc related to threading.
+ */
stonithd_log2(LOG_DEBUG, "client [pid: %d] want a
STONITH "
"operation %s to node %s."
, ch->farside_pid
@@ -2545,6 +2560,11 @@
stonithd_log(LOG_ERR, "on_stonithd_virtual_stonithRA_ops: "
"not signoned yet.");
if ( NULL!= (ra_op = new_stonithRA_ops_t(request)) ) {
+ /*
+ * FIXME: ch->farside_pid cannot be relied on.
+ * It only works on Linux -- and then not too reliably
+ * - because of bugs in glibc related to threading.
+ */
stonithd_log2(LOG_DEBUG, "client [pid: %d] want a "
"resource operation %s on stonith RA %s "
"[resource id: %s]"
@@ -3596,6 +3616,9 @@
/*
* $Log: stonithd.c,v $
+ * Revision 1.101 2006/08/18 20:39:51 alan
+ * Bug 1412: Marked source FIXME where bug 1412 occurs
+ *
* Revision 1.100 2006/07/17 07:42:41 sunjd
* (bug1379) This doesnot always indicate a error scenario
*
------------------------------
_______________________________________________
Linux-ha-cvs mailing list
Linux-ha-cvs@lists.linux-ha.org
http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs
End of Linux-ha-cvs Digest, Vol 33, Issue 81
********************************************
